Custom Query (964 matches)

Ticket corrects the following:

• An update was made in ​src:ticket:373 to use the level of no motion when computing the balanced free-surface contribution in the balance operator. This strategy is only needed when integrating the non-hydrostatic relationship from the level of no motion (LNM_depth) to the surface.

This strategy is not needed when ZETA_ELLIPTIC is activated since an elliptical equation is solved (Fukumori et al., 1998; Weaver et al. 2005) to avoid the need for a level of no motion in the vertical integration. Therefore, ad_banlance.F, tl_balance.F, and zeta_balanced.F were changed to remove this integration option.

• Changed the Version variable to 3.4 in mod_ncparam.F:

           character (len=5  ) :: version = '3.4  '
  

• Allowed integer overflow in ran_state.F when using the gfortran compiler (Linux-gfortran.mk, CYGWIN-gfortran.mk, MINGW-gfortran.mk):

  $(SCRATCH_DIR)/ran_state.o: FFLAGS += -fno-strict-overflow
  

  Many thanks to Alexander Barth for ​reporting and solving this problem.

Corrected a typo in varinfo.dat when defining the metadata for the sand_north_ boundary variable. The following definition was changed from

'sand_north_'                                      ! Input
  'suspended noncohesive sediment northern boundary condition'
  'kilogram meter-3'                               ! [kg/m3]
  'sand_north_, scalar, series'
  'sand_time'
  'idTbry(inorth,idmud(i))'
  'nulvar'
  1.0d0

to

'sand_north_'                                      ! Input
  'suspended noncohesive sediment northern boundary condition'
  'kilogram meter-3'                               ! [kg/m3]
  'sand_north_, scalar, series'
  'sand_time'
  'idTbry(inorth,isand(i))'
  'nulvar'
  1.0d0

The incorrect token idTbry(inorth,idmud(i)) affected the northern boundary condition for noncohesive sediments since it was not assigned (idTbry(:,4)=0). This bug has been in varinfo.dat for awhile. Many thanks to Xiang-Ming Zeng for ​reporting this problem.

I also corrected a typo in all ocean.in input scripts when describing LtracerSrc in glossary section. This typo just affected its documentation.

There is a typo in sediment_var.h when assigning the river runoff indices for noncohesive sediment tracers. We need to have instead:

              CASE ('idRtrc(isand)')
                load=.FALSE.
                IF (NNS.gt.0) THEN
                  varid=varid-1
                  DO i=1,NNS
                    varid=varid+1
                    idRtrc(isand(i))=varid
                    DO ng=1,Ngrids
                      Fscale(varid,ng)=scale
                      Iinfo(1,varid,ng)=gtype
                    END DO
                    WRITE (Vname(1,varid),'(a,i2.2)')                   &
     &                    TRIM(ADJUSTL(Vinfo(1))), i
                    WRITE (Vname(2,varid),'(a,a,i2.2)')                 &
     &                    TRIM(ADJUSTL(Vinfo(2))), ', size class ', i
                    WRITE (Vname(3,varid),'(a)')                        &
     &                    TRIM(ADJUSTL(Vinfo(3)))
                    WRITE (Vname(4,varid),'(a,a)')                      &
     &                    TRIM(Vname(1,varid)), ', scalar, series'
                    WRITE (Vname(5,varid),'(a)')                        &
     &                    TRIM(ADJUSTL(Vinfo(5)))
                  END DO
                  varid=varid+1
                END IF

Many thanks to Xiang-Ming Zeng for ​reporting this problem.