Custom Query (986 matches)

The application ADRIA02 of ROMS 3.0 (with no modification whatsoever) does not run when using MPI and NtileI*NTileJ > 1. ROMS remain stuck forever at

INITIAL: Configurating and initializing forward nonlinear model ...

It runs correctly with NtileI=NtileJ = 1. Disabling UV_PSOURCE and TS_PSOURCE gives a correct behavior.

This problem occured on a AltiX system with ifort 8.1 I am ready to help as much as possible if the bug is not reproducible.

Mathieu

A few bugs, discovered while trying to compile BL_TEST case:

• Fortran include statements don't work; replace with #include

• Extraneous stuff at end of file; remove.

• Variable ng declared as argument *and* as local variable in initialize_atmos_coupling.

Modified version attached. However BL_TEST still won't compile, I get

cd Build; g95 -c -fno-second-underscore -O3 -ffast-math ad_conv_3d.f90 /usr/bin/cpp -P -traditional -I/usr/local/include-g95 -DCYGWIN -DI686 -DG95 -D'ROOT_DIR="/tmp/hadfield/src"' -DBL_TEST -D'HEADER="bl_test.h"' -D'ROMS_HEADER="bl_test.h"' -DNestedGrids=1 -D'ANALYTICAL_DIR="/tmp/hadfield/src/ROMS/Functionals"' -D'SVN_REV="exported"' -IROMS/Include -IROMS/Adjoint -IROMS/Nonlinear -IROMS/Representer -IROMS/Tangent -IROMS/SeaIce -IROMS/Utility -IROMS/Drivers -IROMS/Functionals -IMaster -D'HEADER_DIR="./ROMS/Include"' ROMS/Adjoint/ad_convolution.F > Build/ad_convolution.f90 ROMS/Adjoint/ad_convolution.F:1: cppdefs.h: No such file or directory

When compiled with explicit-shape declarations, subroutine ana_psource_grid (file ROMS/Functionals/ana_psource.h, revision 48) contains

integer, intent(out)

Nsrc

and later there are several arguments dimensioned with this, eg:

logical, intent(out)

Lsrc(Nsrc,NT(ng))

integer, intent(out)

Isrc(Nsrc)

So Lsrc, Isrc, etc are dimensioned with an intent(out) argument, which is illegal and obviously problematic, as the compiler needs to knwo the dimensions before calling the subroutine. However Nsrc can't be made intent(in) as its value is specified inside the subroutine.

Arguments Lsrc, Isrc, etc need to be declared with the same dimensions as the actual arrays they correspond to, namely SOURCES(ng)%Lsrc, SOURCES(ng)%Isrc, etc. The dimensions are determined when they are allocated in subroutine allocate_sources, module mod_sources, the declarations above should be

logical, intent(out)

Lsrc(Msrc,NT(ng))

integer, intent(out)

Isrc(Msrc)

This value has to be fed to the subroutine somehow. I've done it with

#ifndef ASSUMED_SHAPE

USE mod_sources, ONLY : Msrc

#endif

but alternatively it could be fed in as an extra argument.

Corrected file is attached.