Custom Query (964 matches)

• The variables associated with depth are special in ROMS because of wetting/drying and other algorithms. We cannot add a _FillValue in output NetCDF files. Although the output variables z_rho, z_u, z_v, and z_w are defined with SetFillVal = .FALSE. in module def_his.F, the same optional variable is missing when writing in wrt_his.F and wrt_quick. For example, we need to have in wrt_his.F instead:

  !
  !  Write time-varying depths of RHO-points.
  !
        IF (Hout(idpthR,ng)) THEN
          scale=1.0_dp
          gtype=gfactor*r3dvar
          status=nf_fwrite3d(ng, model, HIS(ng)%ncid,                     &
       &                     HIS(ng)%Vid(idpthR),                         &
       &                     HIS(ng)%Rindex, gtype,                       &
       &                     LBi, UBi, LBj, UBj, 1, N(ng), scale,         &
  # ifdef MASKING
       &                     GRID(ng) % rmask,                            &
  # endif
       &                     GRID(ng) % z_r,                              &
       &                     SetFillVal = .FALSE.)
          IF (FoundError(status, nf90_noerr, __LINE__, MyFile)) THEN
            IF (Master) THEN
              WRITE (stdout,10) TRIM(Vname(1,idpthR)), HIS(ng)%Rindex
            END IF
            exit_flag=3
            ioerror=status
            RETURN
          END IF
        END IF
  

  To avoid those land values being read in MATLAB as 1e+37. Those variables were written correctly in wrt_dai.F, which is used for EnKF and 4D-Var.

• Corrected typo in def_his.F when defining implicit omega vertical velocity.

• Updated metadata varinfo.yaml to include omega_implicit and added scale factor 1/rho0 for wave dissipation variables.

Parker MacCready's student Aurora Leeson ​identifies in the ROMS Forum what appears to be a bug in the processing of LuvSrc / LwSrc options in the particular combination that a user has a mix of BOTH LwSrc and LuvSrc sources (functionality we recently allowed following discussion with John Warner) AND not all the LuvSrc sources are in the u-direction (it is a quirky combination to trigger an error).

In step3d_uv.F, we need to have instead:

!
!-----------------------------------------------------------------------
! Apply momentum transport point sources (like river runoff), if any.
!-----------------------------------------------------------------------
!
      IF (LuvSrc(ng)) THEN
        DO is=1,Nsrc(ng)
          i=SOURCES(ng)%Isrc(is)
          j=SOURCES(ng)%Jsrc(is)
          IF (((IstrR.le.i).and.(i.le.IendR)).and.                      &
     &        ((JstrR.le.j).and.(j.le.JendR))) THEN
            IF (INT(SOURCES(ng)%Dsrc(is)).eq.0) THEN
              DO k=1,N(ng)
                cff1=1.0_r8/(on_u(i,j)*                                 &
     &                       0.5_r8*(z_w(i-1,j,k)-z_w(i-1,j,k-1)+       &
     &                               z_w(i  ,j,k)-z_w(i  ,j,k-1)))
                u(i,j,k,nnew)=SOURCES(ng)%Qsrc(is,k)*cff1
              END DO
            ELSE IF (INT(SOURCES(ng)%Dsrc(is)).eq.1) THEN
              DO k=1,N(ng)
                cff1=1.0_r8/(om_v(i,j)*                                 &
     &                       0.5_r8*(z_w(i,j-1,k)-z_w(i,j-1,k-1)+       &
     &                               z_w(i,j  ,k)-z_w(i,j  ,k-1)))
                v(i,j,k,nnew)=SOURCES(ng)%Qsrc(is,k)*cff1
              END DO
            END IF
          END IF
        END DO
      END IF

Notice that when Dsrc(is) = 2, no contribution is added to u and v. That is done as volume vertical influx in omega.F.

Propagated change to the TLM, RPM, and ADM versions of step3d_uv.F.

The GitHub ​https://github.com/myroms/roms_test is updated to include changes to the IRENE coupling application:

• The subdirectory IRENE/Coupling now includes two subdirectories:
  
  
  • data_wrf_roms: ESMF/NUOPC coupling with three components: DATA-WRF-ROMS using ROMS native coupling framework.
    
    
  • roms_data: ESMF/NUOPC coupling with two components: ROMS-DATA. It tests the native ROMS NUOPC cap modules for ROMS and DATA components.

• It also serves as an example to couple to the UFS using CDEPS/CMEPS. Thus, we may include other subdirectories in the future to show the interface to the UFS.

• Corrected the units attribute for variable Tair in IRENE/Data/FRC/Tair_narr_IRENE.nc. It needs to be Celsius instead of Kelvin.