Custom Query (964 matches)

A new docs subdirectory is added to the repository. It currently has the README.md file. In the future, it will contain additional documents and information files that can be used in ​ROMS doxygen.

Removed the initialization of 3D boundary indices in mod_ncparam.F for shallow-water applications where SOLVE3D is undefined. Now we have:

!
!  Set generic lateral boundary indices for LBC structure. Use the same
! values of the state variables at the same C-grid location. Generic
! indices are used for testing periodicity. The PSI-variables and
! W-variables are assigned the same value as the RHO-variables.
!
      isBp2d=isFsur                           ! 2D PSI-variables
      isBr2d=isFsur                           ! 2D RHO-variables
      isBu2d=isUbar                           ! 2D U-variables
      isBv2d=isVbar                           ! 2D V-variables
#if defined SOLVE3D
      isBp3d=isTvar(1)                        ! 3D PSI-variables
      isBr3d=isTvar(1)                        ! 3D RHO-variables
      isBu3d=isUvel                           ! 3D U-variables
      isBv3d=isVvel                           ! 3D V-variables
      isBw3d=isTvar(1)                        ! 3D W-variables
# if defined GLS_MIXING || defined MY25_MIXING
      isMtke=isTvar(MT)+1                     ! turbulent variables
# endif
#endif

In 2D applications, the total number of tracers, MT=0. Therefore, the isTvar vector is allocated as

     IF (.not.allocated(isTvar)) THEN
       allocate ( isTvar(MT) )
       Dmem(1)=Dmem(1)+REAL(MT,r8)
     END IF

Thus, we have only access to element zero of the vector isTvar, which may trigger a segmentation violation when accessing isTvar(1).

Many thanks to Moein DoostMohammadi for ​bringing this issue to my attention.

• Unified the location of cpp_clean in standalone ROMS and ROMS-JEDI for CMake configuration. In Compilers/roms_functions.cmake we now have:

  # Functions used in CMake to overcome its rudimentary capabilities.
  
  find_program(
    GREP
    NAMES grep egrep
    DOC "Grep command"
    REQUIRED
  )
  
  find_program(
    PERL
    NAMES perl
    DOC "Perl command"
    REQUIRED
  )
  
  find_program(
    CPP_CLEAN
    NAMES cpp_clean
    HINTS "${CMAKE_CURRENT_SOURCE_DIR}/ROMS/Bin/"
    DOC "ROMS CPP Clean command"
    REQUIRED
  )
  
  find_program(
    CPP_EXECUTABLE
    NAMES cpp
    DOC "C-preprocessor command"
    REQUIRED
  )
  
  message( STATUS "CMAKE_SOURCE_DIR=${CMAKE_SOURCE_DIR}" )
  message( STATUS "CMAKE_CURRENT_SOURCE_DIR=${CMAKE_CURRENT_SOURCE_DIR}" )
  message( STATUS "CPP_CLEAN=${CPP_CLEAN}" )
  

• Added CMake (cbuild_roms.csh and cbuild_roms.sh) scripts to all the applications in the test repository. As build_roms.csh and build_roms.sh, they can be used for any version of ROMS in the git and svn repositories.