Custom Query (964 matches)

Updated all the input scripts in ROMS test repository to include the nesting parameters. I also added the DOGBONE test case for nesting with composite and refinement configurations:

dogbone/Composite/
                  ana_vmix.h
                  build.bash
                  build.sh
                  dogbone.h
                  ocean_dogbone.in
                  ocean_dogbone.in
                  dogbone.h
 
dogbone/Data/
             dogbone_grd_href3.nc
             dogbone_grd_left.nc
             dogbone_grd_right.nc
             dogbone_grd_whole.nc
             dogbone_ini_href3.nc
             dogbone_ini_left.nc
             dogbone_ini_whole.nc
             dogbone_ini_right.nc
             dogbone_ngc_composite.nc
             dogbone_ngc_refined.nc

dogbone/Refined/
                ana_vmix.h
                build.bash
                build.sh
                dogbone.h
                ocean_dogbone.in

dogbone/Whole/
              ana_vmix.h
              build.bash
              build.sh
              dogbone.h
              ocean_dogbone.in

The nested grid contact points NetCDF files (dogbone_ngc_*.nc) were created using script contact.m from ROMS Matlab repository.

Several scripts used to compute nesting contact points where updated:

matlab/grid/
            contact.m
            c_contact.m
            grid_perimeter.m
            read_contact.m
            write_contact.m

matlab/netcdf/
              roms_metadata.m

In revision 658, ticket 584, an extra optional argument named KeyWord was added to the find_file function in ROMS/Utility/inp_par.F. However optional arguments are only valid for external functions with an explicit interface (eg. those declared inside a module) which does not apply in this case.

The interesting thing is that this violation of the Fortran standard does not cause any problems on some compilers (eg. Gfortran). However with xlf on AIX on a case I have run, the length of the file name argument inside find_file is incorrect at run-time, meaning that the file is reported to be missing when in fact it exists.

Noting that all the calls to find_file in the ROMS code do actually have the extra argument, the simplest solution is to remove the optional keyword.

(Putting all the procedures in inp_par.F inside a module would be a good idea, too, but I vaguely recall that there is a reason not to do this.)