Custom Query (964 matches)
Results (598 - 600 of 964)
Ticket | Owner | Reporter | Resolution | Summary |
---|---|---|---|---|
#558 | Fixed | IMPORTANT: Ambigous local variable name in distribute.F | ||
Description |
The variable Aout was ambiguous in routines mp_aggregate2d and mp_aggregate3d in module distribute.F. These two new routines are used in nesting. The variable Aout is also declared in module mod_ncparam.F as a logical switch for time-averaged output fields. This error was detected correctly when compiling with gfortran. The other compilers bypassed this bug. It is amazing how compilers relax the Fortran standard nowadays. I missed this one. There are so many variables in ROMS that sometimes I forget some of them. Many thanks to Rich Signell for bringing this to my attention. |
|||
#559 | Fixed | Corrected bug with the mass point sources, Q_PSOURCE | ||
Description |
The option Q_PSOURCE was corrected in step3d_t.F so it is only activated to the desired tracers using: DO is=1,Nsrc IF (LtracerSrc(itrc,ng)) THEN ... DO k=1,N(ng)-1 FC(i,k)=FC(i,k)+0.5_r8* & & (Qsrc(is,k )*Tsrc(is,k ,itrc)+ & & Qsrc(is,k+1)*Tsrc(is,k+1,itrc)) END DO END IF END DO Notice also that the k-loop range was corrected. We need to have k=1,N(ng)-1. This update to the FC flux is only at the interior since it defined at W-points and Qsrc is only possible at RHO-points. Many thanks to Lyon Lanerolle for bringing this to my attention. |
|||
#560 | Fixed | Bug in NEMURO, if HOLLING_GRAZING is activated | ||
Description |
There is a bug in the NEMURO model for the grazing of small zooplankton when the option HOLLING_GRAZING is activated. At line 670 of nemuro.h there is a ** where there should be a *: ! ! Predactory Zooplankton grazing on Small Zooplankton, GraZS2ZP. ! #if defined IVLEV_EXPLICIT cff4=1.0_r8-EXP(LamP(ng)*(ZS2ZPstar(ng)-Bio(i,k,iSzoo))) cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo)) GraZS2ZP=fac6*cff3*cff5*MAX(0.0_r8,cff4)*Bio(i,k,iPzoo) Bio(i,k,iSzoo)=Bio(i,k,iSzoo)-GraZS2ZP Bio(i,k,iPzoo)=Bio(i,k,iPzoo)+GraZS2ZP #else # ifdef HOLLING_GRAZING cff4=1.0_r8/(KZS2ZP(ng)+Bio(i,k,iSzoo)*Bio(i,k,iSzoo)) cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo)) !> wrong cff=fac6*cff3**cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo) cff=fac6*cff3*cff4*cff5*Bio(i,k,iPzoo)*Bio(i,k,iSzoo) # elif defined IVLEV_IMPLICIT cff4=1.0_r8-EXP(LamP(ng)*(ZS2ZPstar(ng)-Bio(i,k,iSzoo))) cff5=EXP(-PusaiZS(ng)*Bio(i,k,iLzoo)) cff6=1.0_r8/(fac6*cff4) cff=(1.0_r8+Bio(i,k,iSzoo)*cff6)*cff3*cff5*Bio(i,k,iPzoo) # endif Bio(i,k,iSzoo)=Bio(i,k,iSzoo)/(1.0_r8+cff) GraZS2ZP=cff*Bio(i,k,iSzoo) Bio(i,k,iPzoo)=Bio(i,k,iPzoo)+GraZS2ZP #endif Many thanks to Chris Edwards for bringing this to our attention. |