Custom Query (964 matches)

Corrected couple of typos:

• ad_t3dbc_im.F: A line was removed when processing the modifications to the lateral boundary conditions (​src:ticket:519). At line 115, we need to have:

              ad_t(Iend+1,Jend+1,k,nout,itrc)=0.0_r8
  

• read_phypar.F: At line 1434, we need to have instead:

                IF (idVair.eq.0) THEN
  

  Many thanks to Hugo Bastos for ​reporting this typo.

• mod_forces.F: corrected a typo in the module documentation.

Corrected a bug in routine load_s2d of inp_par.F when advancing the counter in the multiple file, split record option when processing the standard input ocean.in.

Around line 1779 of inp_par.F we need to have instead:

      IF (.not.load) THEN
        IF (ifile.lt.nFfiles(igrid)) THEN
          ifile=ifile+MIN(1,Icont)
        ELSE
          ifile=1
          igrid=igrid+MIN(1,Icont)
        END IF
      END IF
      ...

We need to have the .lt. operator in the conditional IF-statement instead of .le., many thanks to Kate Hedstrom for ​bringing this to my attention.

I also corrected a typo in Data/ROMS/CDL/grd_spherical.cdl, the double quotes were missing in the units attributes for the bottom drag variables.

Corrected a nasty bug in the Generalized Stability Theory (GST) adjoint-based propagators for periodic applications. We have been hunting on and off for this bug for the last six months. It was very frustrating because we didn't have a clue. We systematically searched for the bug and finally found it in the last thing that we checked. It was in the packing and unpacking routines of the state vector that communicates with the ARPACK library, packing.F. We just ignored that IstrU and IstrV is 1 in periodic applications and not 2 for the tiles adjacent to the boundary.

Rats... it is not the first time that we introduce bugs with that nasty logic in periodic boundary conditions.

A new test case is added CHANNEL for a uniform periodic channel. We are adding this one to the test suite. It is a very simple test for the Optimal Perturvation eigenfunction. It also illustrate how to use the error function package in the ROMS/Utility/erf.F module. This module has very convenient mathematical functions that are not part of the standard Fortran:

 ERF        Error function, ERF(x)
 ERFC       Complementary error function, ERFC(x)
 ERFCC      Complementary error function, ERFCC(x), cheaper Chebyshev fitting approximation
 GAMMP      Incomplete gamma function, P(a,x)
 GAMMQ      Incomplete gamma function complement, Q(a,x)=1-P(a,x)

These functions can be used to code a variety of analytical solutions.

Many thanks to Andy Moore for his help searching for this bug and coming up with an analytical test case. Also thank you to Kevin Smith for running the test cases.

I also corrected a typo in read_phypar.F. Many thanks to John Luick for bringing this to my attention.