Custom Query (964 matches)
Results (382 - 384 of 964)
Ticket | Owner | Reporter | Resolution | Summary |
---|---|---|---|---|
#318 | Done | Updated 4DVAR adjustment of open boundaries | ||
Description |
This is a big update to the 4DVAR adjustment of open boundaries, ADJUST_BOUNDARY. Several bugs were corrected. Also, the adjustment of 2D momentum at the open boundaries was revisited. This adjustment is now computed by integrating the 3D momentum increments. This is consistent with other adjoint-based algorithms. Many thanks to Andy Moore for his great help in debugging and testing this algorithm. The following changes were coded:
I also corrected couple of bugs reported by Gregoire Broquet and Jerome Fiechter. |
|||
#320 | Fixed | More corrections to the 4DVAR adjustment of open boundaries | ||
Description |
Additional changes were made to the 4DVAR adjustment of open boundaries, ADJUST_BOUNDARY. We need to separate the adjustment of 2D momentum in 3D applications. The modules tl_obc_adjust.F, rp_obc_adjust.F, and ad_obc_adjust.F now have an additional routine to compute the vertical integral of 3D momentum increments used in the 2D momentum adjustments. These are now computed in tl_obc2d_adjust, rp_obc2d_adjust, and ad_obc2d_adjust, respectively. Also corrected rp_set_depth_bry. This routine is special and now is equivalent to tl_set_depth_bry. The additional terms that are added during the representer (finite amplitude tangent linear) model transformation are not needed here because of the way that the adjustments to the boundary are computed. As always, many thanks to Andy Moore for his help in debugging and testing this algorithm. |
|||
#322 | Fixed | Missing index in 4DVAR boundary adjustments | ||
Description |
The ib index was not assigned in ad_variability.F and tl_variability.F. This was giving the incorrect error covariance at the boundaries. Also corrected ana_perturb.h for boundary forcing with delta functions. A bug was also corrected in cgradient_lanczos.h when the ADJUST_WSTRESS option was activated. The variable ad_vstr was passed as argument to state_dotprod instead of tl_vstr during preconditioning. Many thanks to Andy Moore and Gregorie Broquet for reporting these bugs. |