Custom Query (964 matches)

Corrected a problem in checkvars.F in sediment or BBL applications when the bottom properties are specified with analytical expressions (ANA_SEDIMENT).

# if defined SEDIMENT || defined BBL_MODEL
#  ifndef ANA_SEDIMENT
         DO itrc=1,MBOTP
           get_var(idBott(itrc))=.TRUE.
         END DO
#  endif
# endif

The conditional # ifndef ANA_SEDIMENT was missing. This forced to look for this variables in the initial conditions NetCDF file.

Recall that it is possible to combine analytical expression with physical initial conditions (zeta, u, v, T, S) in the NetCDF file in sediment or biology models applications. If either ANA_SEDIMENT or ANA_BIOLOGY are activated, the user needs to provide analytical expressions for all the state variables associated with these models.

Many thanks to Laura Bianucci for reporting this in the ​forum. Also many thanks to John Wilkin and Chris Sherwood for bringing this to my attention.

There is a misplaced CPP conditional in normalization.F when the ADJUST_WSTRESS option is used alone.

Many thanks to Ha Joon Song for reporting this problem in the ​forum.

If WET_DRY is defined and Vstretching 2 or 3 is used, ROMS will quit with an error message if there it topography above the level of the free-surface (which is generally the case in WET_DRY applications).

There are two problems:

1. Looking at set_scoord.F, I see that the following lines only occur

in the Vstreching == 1 case:

# if defined WET_DRY
       hc(ng)=MIN(MAX(hmin(ng),0.0_r8),Tcline(ng))
# else
       hc(ng)=MIN(hmin(ng),Tcline(ng))
# endif

This code should be executed before the check of which stretching function was used so that it applies to all stretching functions.

2. In the Vstretching=2,3 sections of the code, these lines:

       hc(ng)=Tcline(ng)
       IF (hc(ng).le.hmin(ng)) THEN
        ELSE

and

          WRITE (stdout,10) hc(ng), hmin(ng)
          exit_flag=5
        END IF

should be removed, as in the Vstretching = 1 case.

My modified set_scoord.F is attached.