Possible bug in obs_k2z.F

Bug reports, work arounds and fixes

Moderators: arango, robertson

Post Reply
Message
Author
stef
Posts: 187
Joined: Tue Mar 13, 2007 6:38 pm
Location: Independent researcher
Contact:

Possible bug in obs_k2z.F

#1 Unread post by stef »

I think there is a bug at the following line in obs_k2z.F:

https://github.com/myroms/roms/blob/5ca ... k2z.F#L187

(src:trac:960, git branch develop at 5ca8b9d05592)

Should this

Code: Select all

r2=REAL(k2-k1,r8)*(Zobs(iobs)-REAL(k1,r8))
be instead

Code: Select all

r2=REAL(k2-k1,r8)*((Zobs(iobs)-0.5)-REAL(k1,r8))
? Note that 3 lines above, k1 is computed with with (Zobs(iobs)-0.5), to convert from k_rho to k_w. So the same have to done here?

If this a bug, is it right that this only affects output (via stats_modobs.F) and has no impact on the calculations (at least in the master branch)?

Thanks for your help!

Post Reply